Skip to content

Remove unused field #127494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 6, 2025
Merged

Remove unused field #127494

merged 8 commits into from
May 6, 2025

Conversation

@Yuristry
Copy link
Contributor

@Yuristry Yuristry commented Apr 29, 2025

This commit remove unused field

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team v9.1.0 labels Apr 29, 2025
@PeteGillinElastic PeteGillinElastic self-requested a review May 1, 2025 08:09
@PeteGillinElastic PeteGillinElastic self-assigned this May 1, 2025
@PeteGillinElastic PeteGillinElastic added :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >non-issue and removed needs:triage Requires assignment of a team area label labels May 1, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Indexing Meta label for Distributed Indexing team label May 1, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 1, 2025

Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing)

@PeteGillinElastic
Copy link
Member

PeteGillinElastic commented May 1, 2025

buildkite test this

@PeteGillinElastic
Copy link
Member

PeteGillinElastic commented May 1, 2025

Hi @Yuristry, thanks for contributing to Elasticsearch.

This change looks pretty straightforward. The only comment I have is a procedural one: Could you please push a change deleting the changelog? A change like this doesn't need a that, because we wouldn't put this in the release notes. I have labelled the PR as >non-issue, which means the automation will no longer try to add one.

PeteGillinElastic
PeteGillinElastic requested changes May 1, 2025
View reviewed changes
Copy link
Member

@PeteGillinElastic PeteGillinElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above: Please delete the docs/changelog file added here, it is unnecessary (I have labelled the PR as >non-issue to prevent the automation requiring a changelog).

@PeteGillinElastic
Copy link
Member

PeteGillinElastic commented May 1, 2025

I am running tests against this. You can ignore the failures in elasticsearch-ci/validate-changelogs which will go away when you delete that file.

@Yuristry
Copy link
Contributor Author

Yuristry commented May 2, 2025

OK, I have deleted the docs/changelog file. @PeteGillinElastic

@Yuristry Yuristry requested a review from PeteGillinElastic May 2, 2025 14:52
@PeteGillinElastic
Copy link
Member

PeteGillinElastic commented May 2, 2025

buildkite test this

PeteGillinElastic
PeteGillinElastic approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@PeteGillinElastic PeteGillinElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM. I have kicked off another test run, and I will merge it if that passes.

@PeteGillinElastic
Copy link
Member

PeteGillinElastic commented May 2, 2025

buildkite test this

@PeteGillinElastic PeteGillinElastic merged commit c761b0c into elastic:main May 6, 2025
19 checks passed
@PeteGillinElastic
Copy link
Member

PeteGillinElastic commented May 6, 2025

Hi @Yuristry. This is now merged. Thanks again for your contribution to Elasticsearch!

@Yuristry Yuristry deleted the remove-unused-field branch May 6, 2025 13:00
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request May 9, 2025
@Yuristry @ywangd
Remove unused field (elastic#127494)
722e6f5
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request May 12, 2025
@Yuristry @jfreden
Remove unused field (elastic#127494)
6ffb027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeteGillinElastic PeteGillinElastic PeteGillinElastic approved these changes

Assignees

@PeteGillinElastic PeteGillinElastic

Labels

:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Team:Distributed Indexing Meta label for Distributed Indexing team v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Yuristry @elasticsearchmachine @PeteGillinElastic